[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r32996 - in trunk/subversion: include libsvn_subr

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 9 Sep 2008 11:14:21 -0400

In the future, could you add const in one pass and revision rather
than a dozen 2-line changes? This series was real spammy and no easier
to review (arguably harder)

Thx,
-g

On Sep 9, 2008, at 2:16, blair_at_tigris.org wrote:

> Author: blair
> Date: Mon Sep 8 23:16:32 2008
> New Revision: 32996
>
> Log:
> * subversion/include/svn_cache.h,
> * subversion/libsvn_subr/cache.c
> (svn_cache_iter)
> Take a const svn_cache_t * instead of a svn_cache_t *.
>
> Modified:
> trunk/subversion/include/svn_cache.h
> trunk/subversion/libsvn_subr/cache.c
>
> Modified: trunk/subversion/include/svn_cache.h
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/include/svn_cache.h?pathrev=32996&r1=32995&r2=32996
> ===
> ===
> ===
> =====================================================================
> --- trunk/subversion/include/svn_cache.h Mon Sep 8 23:12:39 2008
> (r32995)
> +++ trunk/subversion/include/svn_cache.h Mon Sep 8 23:16:32 2008
> (r32996)
> @@ -263,7 +263,7 @@ svn_cache_set(svn_cache_t *cache,
> */
> svn_error_t *
> svn_cache_iter(svn_boolean_t *completed,
> - svn_cache_t *cache,
> + const svn_cache_t *cache,
> svn_iter_apr_hash_cb_t func,
> void *baton,
> apr_pool_t *pool);
>
> Modified: trunk/subversion/libsvn_subr/cache.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_subr/cache.c?pathrev=32996&r1=32995&r2=32996
> ===
> ===
> ===
> =====================================================================
> --- trunk/subversion/libsvn_subr/cache.c Mon Sep 8 23:12:39
> 2008 (r32995)
> +++ trunk/subversion/libsvn_subr/cache.c Mon Sep 8 23:16:32
> 2008 (r32996)
> @@ -79,7 +79,7 @@ svn_cache_set(svn_cache_t *cache,
>
> svn_error_t *
> svn_cache_iter(svn_boolean_t *completed,
> - svn_cache_t *cache,
> + const svn_cache_t *cache,
> svn_iter_apr_hash_cb_t user_cb,
> void *user_baton,
> apr_pool_t *pool)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: svn-help_at_subversion.tigris.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-09 17:16:54 CEST

This is an archived mail posted to the Subversion Dev mailing list.