[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r32265 - branches/issue-2843-dev/subversion/libsvn_wc

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Thu, 28 Aug 2008 11:54:58 -0400

"Rui, Guo" <timmyguo_at_mail.ustc.edu.cn> writes:
>> Is this forward declaration really necessary? Why not just put
>> the definition of do_entry_deletion() here instead? (I looked at its
>> body, and didn't see any circular dependencies that would require a
>> forward declaration... Was it the call to leftmod_error_chain() you were
>> worried about?)
>>
> The forward declaration is not necessary but results in less modification. I
> did not think much about this, should I move the whole function altogether
> instead?

I think moving the whole function now would be fine, yes. Thanks!

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-28 17:55:10 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.