"Chia-liang Kao" <clkao_at_clkao.org> writes:
> Please ignore the previous one. There were some inconsistency in the
> updated run_hook_cmd.
*nod* Got it; I've deleted the previous and am considering only this
one. More soon...
-Karl
> [[[
>
> Allow pre-lock hook to be able to specify lock-token to be used with
> stdout output.
>
> **** NOTE ****
>
> This will cause existing pre-lock hook that prints to stdout to be incompatible
> with this change, where the output were previously discarded.
>
> This should be mentioned in the release notes.
>
> * subversion/libsvn_repos/fs-wrap.c
> (svn_repos_fs_lock): allow returned new_token from pre-lock hook.
>
> * subversion/libsvn_repos/repos.h
> (svn_repos__hooks_pre_lock): now has additional returned value for token.
>
> * subversion/libsvn_repos/hooks.c
> (run_hook_cmd): allow stdout of hook to be captured and returned.
> Update all callers.
> (svn_repos__hooks_pre_lock): get token from run_hook_cmd.
>
> * subversion/libsvn_repos/repos.c: Document the pre-lock feature for
> token from stdout.
>
> ]]]
>
> 2008/8/25 Chia-liang Kao <clkao_at_clkao.org>:
>> Karl,
>>
>> Thanks for the review. Here's the updated version of the patch that
>> should include all the issues addressed.
>>
>> Cheers,
>> CLK
>>
>> [[[
>>
>> Allow pre-lock hook to be able to specify lock-token to be used with
>> stdout output.
>>
>> **** NOTE ****
>>
>> This will cause existing pre-lock hook that prints to stdout to be incompatible
>> with this change, where the output were previously discarded.
>>
>> This should be mentioned in the release notes.
>>
>> * subversion/libsvn_repos/fs-wrap.c
>> (svn_repos_fs_lock): allow returned new_token from pre-lock hook.
>>
>> * subversion/libsvn_repos/repos.h
>> (svn_repos__hooks_pre_lock): now has additional returned value for token.
>>
>> * subversion/libsvn_repos/hooks.c
>> (run_hook_cmd): allow stdout of hook to be captured and returned.
>> Update all callers.
>> (svn_repos__hooks_pre_lock): get token from run_hook_cmd.
>>
>> * subversion/libsvn_repos/repos.c: Document the pre-lock feature for
>> token from stdout.
>>
>> ]]]
>>
>> 2008/8/19 Karl Fogel <kfogel_at_red-bean.com>:
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-27 21:19:21 CEST