Re: [PATCH] Mark deprecated functions with SVN_DEPRECATED

2008-08-25 08:35:33 Blair Zajac napisał(a):
> Arfrever Frehtes Taifersar Arahesis wrote:
> > The attached patch marks deprecated functions with SVN_DEPRECATED.
> > When such functions are used, compiler will print appropriate warnings.
>
> Hi Arfrever,
>
> Thanks for putting this patch together.
>
> However, the location of SVN_DEPRECATED is odd, as though it's part of the
> pointer return type:
>
> svn_error_t * SVN_DEPRECATED
> svn_opt_print_help2(apr_getopt_t *os,
> const char *pgm_name,
> svn_boolean_t print_version,
>
> Can we move it before the return type of the function?

Do you want SVN_DEPRECATED on separate lines?
I.e. do you prefer:

SVN_DEPRECATED
svn_error_t *
svn_function(args);

... or ...

SVN_DEPRECATED svn_error_t *
svn_function(args);

?

-- 
Arfrever Frehtes Taifersar Arahesis