[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: treeconflicts patch: cosmetic: another missing separator line.

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Fri, 22 Aug 2008 10:47:17 +0300 (Jerusalem Daylight Time)

Neels Janosch Hofmeyr wrote on Fri, 22 Aug 2008 at 00:56 +0200:
> Hi Daniel!
>
> Daniel Shahaf wrote:
> > 2. Do you really need to send a patch for every missing separator line?
> > Remember that not every typo, bad indentation, and strcmp()-that-violates-
> > the-recommended-style (when we still had one) deserves a patch post. :)
>
> True. kfogel, on the other hand, committed such a patch... I can't commit,
> so I can only post changes or ignore them. I figured you'd just choose to
> ignore the post. Should I just ignore these kinds of errors, instead?
>

Personally, before I became committer, I defaulted to ignoring these.
If you decide not to ignore them, you can group them into one submission.
(For example, when we have a "Strip trailing whitespace" commit, it
usually touches the entire tree, {tools,contrib,subversion}/**.)

This applies just to "cosmetic" patches, of course. Patches that change
the semantics of the code or the public API are not cosmetic.

> >
> > 3. Also, could you use tags properly in your subject lines? To me,
> > "treeconflicts patch: cosmetic:" is three long words that I have to
> > actually *read* :) (before I decide I'm not interested in the thread
> > they're on), while the "[PATCH]" and "tree-conflicts" tags are
> > comparatively easier to recognize.
>
> So, a proper subject line for a patch destined for the tree-conflicts branch
> should be
>
> [PATCH] tree-conflicts: foo bar yada
>
> ?

It uses both tags right at the start and in their usual spelling, so,
yes, I think it's better.

> I previously thought I should keep tree-conflicts branch stuff a little
> less loud, as in lower-case non-tagged, to not bother you with it.
>

(I'm going to assume that the word "you" is singular here.)

It's true that not everything should be tagged, but *if* you decide to
tag, then it helps everyone (including me) if you don't invent your own
tags.

> Thanks for your feedback!
> Neels

:)

Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-22 09:47:38 CEST

This is an archived mail posted to the Subversion Dev mailing list.