[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] cosmetic: missing separator line in merge_tests.py

From: Senthil Kumaran S <senthil_at_collab.net>
Date: Thu, 21 Aug 2008 11:13:36 +0530

Karl Fogel wrote:
>> Please include the "Patch by:" clause in the log message.
>
> (Though note that we can always insert that, it's no big deal...)

Ok.

> This error does not mean the patch is out of date w.r.t. trunk, it means
> there's something wrong with the patch itself. Considering that the
> patch does not even have 12 lines, I'm not sure how it manages to be
> malformed on line 12 :-). (The "os.chdir" line in the patch is like
> line 2 or something -- it's just the second line of context.)

I had the patch with log message at the top, thats why it is pointing to the
12th line, else it will point to the 7th line.

<snip>
patching file subversion/tests/cmdline/merge_tests.py
patch: **** malformed patch at line 7: os.chdir(saved_cwd)
</snip>

> Senthil, can you post the patch file you're working with (as an
> attachment of mime type 'text/plain')? We can compare it with Neels'
> original post and figure out what happened here, maybe.

Attached.

-- 
Senthil Kumaran S
http://www.stylesen.org/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org

Received on 2008-08-21 07:44:00 CEST

This is an archived mail posted to the Subversion Dev mailing list.