[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r32538 - trunk/subversion/libsvn_ra_neon

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Wed, 20 Aug 2008 14:37:18 -0400

rhuijben_at_tigris.org writes:
> Log:
> * subversion/libsvn_ra_neon/session.c
> (exchange_capabilities): Following up to r32417, stop setting up client
> capabilities for this request, because they will now automatically
> be added on every request by svn_ra_neon__request_dispatch.
>
> --- trunk/subversion/libsvn_ra_neon/session.c
> +++ trunk/subversion/libsvn_ra_neon/session.c
> @@ -793,10 +793,6 @@ exchange_capabilities(svn_ra_neon__sessi
>
> rar = svn_ra_neon__request_create(ras, "OPTIONS", ras->url->data, pool);
>
> - ne_add_request_header(rar->ne_req, "DAV", SVN_DAV_NS_DAV_SVN_DEPTH);
> - ne_add_request_header(rar->ne_req, "DAV", SVN_DAV_NS_DAV_SVN_MERGEINFO);
> - ne_add_request_header(rar->ne_req, "DAV", SVN_DAV_NS_DAV_SVN_LOG_REVPROPS);
> -
> err = svn_ra_neon__request_dispatch(&http_ret_code, rar,
> NULL, NULL, 200, 0, pool);
> if (err)

Since this function is called 'exchange_capabilities', it might be good
to leave a comment in place of the removed code, explaining why we're
still sending the capabilities here even though it doesn't look like we
are.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-20 20:37:32 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.