[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Do lock tokens need to be unique?

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Tue, 05 Aug 2008 12:00:35 -0400

"Chia-liang Kao" <clkao_at_clkao.org> writes:
> 2008/7/24 Karl Fogel <kfogel_at_red-bean.com>:
>> Chia-liang Kao <clkao_at_clkao.org> writes:
>>> While talking to Karl today I explained that I intend to make the
>>> tokens available for the pre-commit hook, presumably via STDIN. So I
>>> will change the svn_fs_access_add_lock_token to take path along with
>>> token, and add an accessor function to get the path/token pairs out
>>> for pre-commit hook to use. Does this make sense?
>>
>> Yes :-).
>
> I was almost done with the patch, but discovered mod_dav_svn handles this a
> bit differenetly. I had a chat with justin, it seems in protocol layer, when
> committing lock tokens are provided by client in the If header, so the path
> info here is lost.
>
> so in this case we might need to revision the ra_get_commit_editor API to take
> only a list of tokens...

I don't think revving that API is a huge problem.

I didn't understand the "to take only a list of tokens" part, though.
It already takes a hash of lock tokens; anyway, isn't it the paths
you're missing, not the tokens? But the hash is keyed by path...

If you could formally propose the API rev you have in mind, that might
help.

Thanks,
-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-05 18:00:53 CEST

This is an archived mail posted to the Subversion Dev mailing list.