[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix issue #2324

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Tue, 05 Aug 2008 10:31:18 -0400

Senthil, I've made some minor changes to your patch:

    * Adding a trailing period, and losing an extra blank line from the
      default 'servers' file content.
    * Tweaking comments in the code so that neighboring comments make sense.

I have a question, though -- should the 'servers' file "win" over the auth
cache in terms of priority? Seems to me that the auth cache -- which
typically is populated with known-good credentials, should be given
precedence over the 'servers' file. That would allow me to put "cmpilato"
in the [global] section of my servers file and yet not have that contradict
creds in the auth cache which use a different username.

In fact, I guess I kinda expected to see code something like this:

    creds = check-auth-cache
    if (! creds)
       creds = check-servers-file
    if (! creds)
       creds = apr_getusername()

With such an ordering, the servers file effectively becomes just a way to
override the username assumption.

But maybe this discussion was already played out previously and I missed it?

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2008-08-05 16:31:36 CEST

This is an archived mail posted to the Subversion Dev mailing list.