[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix progress callback for ra_svn

From: Stefan Sperling <stsp_at_elego.de>
Date: Sun, 3 Aug 2008 11:00:36 +0200

On Sun, Aug 03, 2008 at 09:58:07AM +0200, Stefan Küng wrote:
> Daniel Shahaf wrote:
> > Index: subversion/libsvn_ra_svn/ra_svn.h
> > ===================================================================
> > --- subversion/libsvn_ra_svn/ra_svn.h (revision 32316)
> > +++ subversion/libsvn_ra_svn/ra_svn.h (working copy)
> > @@ -95,8 +95,6 @@ struct svn_ra_svn__session_baton_t {
> > const char **tunnel_argv;
> > const svn_ra_callbacks2_t *callbacks;
> > void *callbacks_baton;
> > - apr_off_t bytes_read, bytes_written; /* apr_off_t's because that's what
> > - the callback interface uses */
> > };
>
> this changes the struct svn_ra_svn__session_baton_t, which is AFAIK ok
> for trunk. But wouldn't that break some compatibility rules when
> backporting to 1.5.x?

The struct is private to libsvn_ra_svn, so this change does not
affect public API.
Nobody except libsvn_ra_svn should be using this struct directly.

So I don't think it's a problem, even for backports -- people will
just upgrade to a new libsvn_ra_svn shared library and won't see
a difference from the outside.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-03 11:00:26 CEST

This is an archived mail posted to the Subversion Dev mailing list.