Re: [PATCH] fix progress callback for ra_svn

Daniel Shahaf wrote:
> Stefan Küng wrote on Sun, 3 Aug 2008 at 08:50 +0200:
>> new patch attached with hopefully better docstring.
>
> Docstring looks good, but why can't we just get rid of the 'bytes_read'
> and 'bytes_written' struct members? The semantics would be slightly
> different than with your patch, though...
>
> e.g. (untested)

That patch looks good to me. Just one question (see below)

> Index: subversion/libsvn_ra_svn/ra_svn.h
> ===================================================================
> --- subversion/libsvn_ra_svn/ra_svn.h (revision 32316)
> +++ subversion/libsvn_ra_svn/ra_svn.h (working copy)
> @@ -95,8 +95,6 @@ struct svn_ra_svn__session_baton_t {
> const char **tunnel_argv;
> const svn_ra_callbacks2_t *callbacks;
> void *callbacks_baton;
> - apr_off_t bytes_read, bytes_written; /* apr_off_t's because that's what
> - the callback interface uses */
> };

this changes the struct svn_ra_svn__session_baton_t, which is AFAIK ok
for trunk. But wouldn't that break some compatibility rules when
backporting to 1.5.x?

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net