Re: svn commit: r32353 - trunk/subversion/libsvn_subr

kameshj_at_tigris.org wrote:
> Author: kameshj
> Date: Fri Aug 1 11:48:16 2008
> New Revision: 32353
>
> Log:
> Fix 'svn_dso_initialize' which was *silently* failing to create lock
> and causing later accessors to fail.

>
> #if APR_HAS_THREADS
> - apr_thread_mutex_create(&dso_mutex, APR_THREAD_MUTEX_DEFAULT, dso_pool);
> + status = apr_thread_mutex_create(&dso_mutex,
> + APR_THREAD_MUTEX_DEFAULT, dso_pool);
> + if (status)
> + abort();

We're trying to get away from abort()'s in our library code.

How about creating svn_dso_initialize2() that returns an apr_status_t and the
caller can decide how to handle it. Then svn_dso_initialize() can call
svn_dso_initialize2() and then abort if it fails. But this gives our users a
way to upgrade and void abort()'s.

Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-01 20:59:31 CEST