Re: r31875, Fix 'svn log --xml' against pre-1.2 servers, proposed for back-port.

I have reviewed this change and am voting "+1" for back-port.

However, the STATUS file says "Fix 'svn log --xml' against pre-1.2
servers" but the log message says "This only affects pre-1.1 servers.":

> r31875 | hwright | 2008-06-25 01:02:14 +0100 (Wed, 25 Jun 2008) | 11 lines
>
> Don't send the SVN_INVALID_REVNUM log entry if we bailed out of the log
> messages for compat reasons. This is a holdover from the days when every
> level of nesting needed a SVN_INVALID_REVNUM terminator, but we removed
> that for the outermost level. This only affects pre-1.1 servers.
>
> Found by: Anders Kvist <kvist_at_cego.dk>
>
> * subversion/libsvn_ra_neon/log.c
> (svn_ra_neon__get_log): Don't send the extra SVN_INVALID_REVNUM entry
> after bailing for compat reasons.

Please can we be clear on which versions the compatibility is for?

This appears to be a follow-up to r26732, the log message of which said:

> r26426 introduced a final sentinel call in ra-{neon,serf,svn} but not
> ra-local, resulting in an extra invalid </logentry> in log --xml output.
> Callers already know the log is finished because control returns from
> svn_ra_get_log2, so just drop this extra receiver call.

I added a reference to r26732 into 31875's log message, to help readers follow the reason behind the change.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-18 15:20:47 CEST