Re: svn commit: r32135 - trunk/tools/dev

Julian Foad wrote:
> Blair, Senthil, are you sure you two aren't misunderstanding one
> another? It looks to me like Blair thinks this patch is updating the
> copyright notice that describes this file, but it's not. Instead, it is
> modifying the action that this script can perform so that it can be used
> this year to update copyright notices in other files. That is a correct
> fix.
>
> Senthil, the words "obvious fix" are not a sufficient explanation of a
> change. You might use those words after the description to indicate why
> you are committing a change to something outside your area, but you
> still need to include a sentence that describes the purpose of the
> change. Something like:

Thanks for the clarification Julian.

> [[[
> Update "check-license.py" so that it can generate license text
> applicable to this year.
>
> (Obvious fix.)
>
> * tools/dev/check-license.py
> (NEW_LICENSE): s/2005/2008/
> ]]]
>
> I think you just need to update the log message.

Log message updated as above.

Thank You.

-- 
Senthil Kumaran S
http://www.stylesen.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org