[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r32083 - trunk/subversion/libsvn_subr

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Tue, 15 Jul 2008 13:22:27 -0400

Stefan Sperling <stsp_at_elego.de> writes:
> You mean this bit, right?
>
> + /* We're interactive, and the client provided a
> + * prompt callback. So we can ask the user.
> + *
> + * Check for a cached answer before prompting. */
> + svn_boolean_t cached_answer =
> + (svn_boolean_t) apr_hash_get(b->plaintext_answers,
> + realmstring,
> + APR_HASH_KEY_STRING);
> + if (cached_answer)
> + may_save_passphrase = cached_answer;
> + else
> + {
> + /* Nothing cached for this realm, prompt the user. */
> + SVN_ERR((*b->plaintext_passphrase_prompt_func)
> + (&may_save_passphrase,
> + realmstring,
> + b->prompt_baton,
> + pool));

Exactly, yes. Note the '(void *)' case elsewhere, in the call to
apr_hash_set()... a small price to pay for a sane variable type, IMHO.

> Looks good!

Great, thanks.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-15 21:35:33 CEST

This is an archived mail posted to the Subversion Dev mailing list.