[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: AW: Possible access violation in svn_client_copy

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Mon, 07 Jul 2008 12:12:41 -0400

"Michael Pfob" <m.pfob_at_3s-software.com> writes:
> I did some debugging now and I think i found the reason for my problems.
> The reason was that I did not pass a log_msg_func. The code in
> repos_to_repos_copy in my opinion is wrong because the check for
> SVN_CLIENT__HAS_LOG_MSG_FUNC executes code with side effects like
> filling the table action_hash which leads to problems in my code.
> I think such a side effect should not happen in this if-branch.
>
> Additionally I tried to format my original post correctly.

Thank you for tracing this.

I think you're right: the "if (SVN_CLIENT__HAS_LOG_MSG_FUNC(ctx)) {...}"
code branch should not enclose code that modifies action hash in a way
that the rest of the function needs. Instead, that code should happen
outside the 'if'.

Since you're already set up to test this easily, would you like to try
writing a patch? (see http://subversion.tigris.org/hacking.html#patches)

If not, don't worry about it. You did provide a reproduction program,
and someone else can take this if you don't have time. But it sounds
like you have all the knowledge needed here, so it would be great if you
could take it all the way to the finish line...

Let us know.

Thanks,
-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-07 18:12:59 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.