[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] issue #3232: ignore mixed EOL in ignored part of commit message (was:Re: Please review & apply my patch)

From: Richard Hartmann <richih.mailinglist_at_gmail.com>
Date: Sat, 5 Jul 2008 15:25:00 +0200

[[[
Fix issue #3232: Actually ignore mixed EOL in ignored part of commit message

* subversion/svn/util.c
  Truncate first, check afterwards
* tests/cmdline/commit_tests.py
  Test mixed EOL both before & after ignore line
]]]

While the tests run with the expected results, trying to actually commit
something with a 'broken' log message does not work. I assume the
error lies with not copying back log_msg into log_msg_string, but I am
not sure. Furthermore, test 30 should fail, but it does not.

Any help appreciated,
Richard

PS: Thanks to danielsh for pointing me to the coding guidelines :)

PPS: Be gentle, neither my C nor my Python is too good. If the
test were written in Perl, well.. ;)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org

Received on 2008-07-05 15:25:16 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.