Re: [PATCH] Expose svn_info_t->depth to JavaHL

Jeremy Whitlock wrote:
> Hi All,
> Attached is a patch that will expose svn_info_t->depth to JavaHL's
> Info2 class. This enhancement will enable me to follow up with
> another patch that will enable JavaHL to check whether a working copy
> path is complete, or not a sparse checkout. (This is something that
> could be used to enhance Subclipse's best practices checks for
> example.) For quick analysis, I have pasted the log message at the
> bottom of this email. Please let me know if there is anything I can
> do to make this patch ready for application.
>
> Take care,
>
> Jeremy
>
> [[[
> Expose the depth member of svn_info_t to JavaHL's Info2 class.
>
> * subversion/bindings/javahl/tests/org/tigris/subversion/javahl/BasicTests.java
> (testBasicInfo2): Updated tests to check depth.
>
> * subversion/bindings/javahl/native/EnumMapper.h
> (mapDepth): New function.
>
> * subversion/bindings/javahl/native/EnumMapper.cpp
> (mapDepth): Implementation.
>
> * subversion/bindings/javahl/native/InfoCallback.cpp
> (createJavaInfo2): Updated to call new depth-aware constructor.
>
> * subversion/bindings/javahl/src/org/tigris/subversion/javahl/Info2.java
> (Info2): Updated constructor for depth argument.
> (getDepth, setDepth): New functions.
> ]]]

Jeremy,
Thanks for the patch. I tweaked the log message just a tad and
committed this in r31936.

I noticed that this patch had the mime-type of application/octet-stream.
  That makes it a bit difficult to review inline. Would it be possible
for you to sent future patches as text/x-diff, text/x-patch, or text/plain?

Thanks,
-Hyrum