Rui, Guo wrote on Wed, 18 Jun 2008 at 21:51 +0800:
> On Tue, Jun 17, 2008 at 09:45:45PM +0300, Daniel Shahaf wrote:
> > firemeteor_at_tigris.org wrote on Tue, 17 Jun 2008 at 05:59 -0700:
> > > Author: firemeteor
> > > Date: Tue Jun 17 05:59:30 2008
> > > New Revision: 31763
> > >
> > > Log:
> > > A small readability tweak suggested and approved by kfogel (Karl Fogel).
> > > I mistakenly did it in my branch. Now, I revert that change and do it in trunk
> > > first.
> > >
> >
> > Please use the standard crediting syntax ("Approved by: kfogel" on
> > a separate paragraph) when committing outside your area. (See HACKING.)
> >
> > Also, for the benefit of future historians, mention branch names and
> > revision numbers liberally. The log message should contain the branch
> > name and/or the revision number of the commit there that you are redoing
> > on trunk.
> >
> > Daniel
>
> I tuned my log message. Thanks for point it out.
>
> Rui
>
Normally the "Approved by:" line comes *after* the initial summary text.
(You should have seen it used this way a few times by now if you have been
following the commits list.) See how I tweaked the log message.
Daniel
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-18 18:43:10 CEST