[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: bug in new plaintext auth-prompt warning

From: Stefan Sperling <stsp_at_elego.de>
Date: Tue, 10 Jun 2008 18:24:40 +0200

On Tue, Jun 10, 2008 at 10:35:22AM -0500, Ben Collins-Sussman wrote:
> I love that our new svn_cmdline_auth_plaintext_prompt() screams murder
> about storing the password in plaintext!

Heh :)

It also haunts people at night if they store their passwords in
plaintext anyway. That's a hidden feature.

> However, I ran into a bug
> this morning with it. svnmucc was passing a NULL prompt baton into it
> (which seems legitimate to me), and the function was just blindly
> dereferencing the baton to find the user's config_path. I made a
> small patch below which conditionalizes the printing of the
> config_path text. It fixes the svnmucc segfault. Any objections to
> my committing this?
>
> (I'm asking before I commit, since I've not been paying detailed
> attention to this new feature.)

Yes, this is a bug. Squash it.

Thanks,
Stefan

  • application/pgp-signature attachment: stored
Received on 2008-06-10 18:25:00 CEST

This is an archived mail posted to the Subversion Dev mailing list.