Re: Help on enhancement #3096

On Mon, Jun 09, 2008 at 12:03:43PM +0200, "Andrés G. Aragoneses" wrote:
> Hello devs.
>
> I just need help on
> http://subversion.tigris.org/issues/show_bug.cgi?id=3096 for:
>
> 1) Reviewing my first patch and, if approved, commit it.
> 2) Answer my question regarding the approach I should follow for the
> next patch.

+1 on moving the Log section to the top. This has always bothered
me a bit. It's annoying having to scroll tons of screens in mutt
sometimes just to get to the log message.

But I do not agree with making the following the default behaviour:

  - The list of changes should be added, instead of inline,
    with an attachment, in order to be able to:
    a) Delete attachments in your mail client tool in order to reduce
       disk space usage.
    b) Extract the diff file as a patch that you can commit to other
       branches if you want to.

As for a), commit lists are high volume by definition, you should
know what you're getting yourself into when you subscribe :)

I'm more inclined to accept b), but not for the reason you
state, cause you really want to use "svn merge" for that!

But if adding a command line flag that allows the script to send
the changes as attachments is possible, I'd say that's fine.

Stefan