[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Let depth-tests-23 pass on Windows for dav|svn and bdb

From: Jens Peters <jpeters7677_at_gmx.de>
Date: Sun, 01 Jun 2008 13:36:47 +0200

Hello there,

As mentioned here earlier I see depth-tests failures on my system with the combination svn | dav and bdb. See
http://svn.haxx.se/dev/archive-2008-05/0166.shtml for details. I finally found some time to dig into it and as a result the attached patch fixes the
issue for me.

I know that this is more an ugly workaround than a real fix. But is seems to work fine and at least all tests are green now (which feels actually
pretty good, +1 to release from me :) ). Any chance that this patch or anything similar can be committed? Note thas this patch is made against
1.5-rc8. I would love to make patch against trunk, but first I would like to know if it will be accepted.

Regards, Jens

[[[
Fix a depth-tests-23 failure (WindowsError: Access is denied) on Windows for the combination [svn | dav] and [bdb].

* subversion/tests/cmdline/depth_tests.py
   Insert one second sleep to give Windows the time to release the Berkeley DB file handles before recreating the repository.
]]]

Index: subversion/tests/cmdline/depth_tests.py
===================================================================
--- subversion/tests/cmdline/depth_tests.py (revision 31532)
+++ subversion/tests/cmdline/depth_tests.py (working copy)
@@ -20,6 +20,7 @@
 
 # General modules
 import os
+import time
 
 # Our testing module
 import svntest
@@ -1264,6 +1265,7 @@
 
   # Reset and do it again, this time from above the working copy.
   svntest.main.safe_rmtree(wc)
+ time.sleep(1)
   wc, ign_a, ign_b, ign_c = set_up_depthy_working_copies(sbox, empty=True)
   expected_output = svntest.wc.State(wc, {
       'iota' : Item(status='A '),

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-01 13:37:14 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.