[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r31427 - trunk/subversion/libsvn_auth_kwallet

From: Stefan Sperling <stsp_at_elego.de>
Date: Fri, 30 May 2008 13:19:35 +0200

On Thu, May 29, 2008 at 08:50:17PM +0300, Daniel Shahaf wrote:
> Arfrever Frehtes Taifersar Arahesis wrote on Thu, 29 May 2008 at 14:35 +0200:
> > 2008-05-27 15:25:49 Stefan Sperling napisaƂ(a):
> > > Index: subversion/libsvn_auth_kwallet/kwallet.cpp
> > > ===================================================================
> > > --- subversion/libsvn_auth_kwallet/kwallet.cpp (revision 31465)
> > > +++ subversion/libsvn_auth_kwallet/kwallet.cpp (working copy)
> > > @@ -167,6 +167,9 @@
> > > }
> > > }
> > > }
> > > +// This function currently closes the wallet if no other application
> > > +// is connected to the wallet. We're waiting for this to be fixed
> > > +// upstream, see https://bugs.kde.org/show_bug.cgi?id=162570
> > > // KWallet::Wallet::disconnectApplication(wallet_name,
> > > // QString::fromUtf8("Subversion"));
> > > return ret;
> > >
> >
> > I propedited svn:log of r31427. I think that it is sufficient.
> >
> >
>
> I agree with Stefan: the code should be self-contained. +1 to the
> patch.

Yes, I think commented out code alone looks weird. It needs explanation.
Looking at the log might not be the first thing the reader will do when
wondering why that code is commented out.

Stefan

  • application/pgp-signature attachment: stored
Received on 2008-05-30 13:30:35 CEST

This is an archived mail posted to the Subversion Dev mailing list.