[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Jens, please try to get more peer review

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Thu, 29 May 2008 10:26:47 -0700

> -------Original Message-------
> From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
> Subject: Re: Jens, please try to get more peer review
> Sent: 29 May '08 10:20
>
> Stefan Sperling wrote on Thu, 29 May 2008 at 17:49 +0200:
> > On Thu, May 29, 2008 at 04:25:00PM +0200, Jens Seidel wrote:
> > > Most of the time because the 'obvious fix'. If there was any doubt
> > > I also wrote to this list. I also just forgot adding this flag at
> > > least once.
> >
> > OK. Maybe we should require obvious fixes to be designated as such?
> > Such as: "Obvious fix: Remove trailing whitespace"
> >
> > This would make it more obvious that the obvious fix rule was applied.
> > Should we update HACKING accordingly?
> >
>
> Maybe "Approved by: obvious fix".

That may confuse the contribulyzer. I think just prefacing the log message with "Obvious fix", much the same way people sometimes do with work on branches, would be fine. I really don't care how it's done, but being explicit about the obvious fix rule being invoked would be a good thing.

-Hyrum

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-29 19:27:00 CEST

This is an archived mail posted to the Subversion Dev mailing list.