[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r31484 - in trunk: . subversion/svn tools/po

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Wed, 28 May 2008 09:47:25 +0100

Jens Seidel wrote:
> Hi Paul,
>
> On Tue, May 27, 2008 at 08:57:21PM -0400, Paul Burba wrote:
>
>>On Tue, May 27, 2008 at 6:54 PM, <jensseidel_at_tigris.org> wrote:
>>
>>>Author: jensseidel
>>>Log:
>>>Use workaround for an xgettext limitation.
>>>
>>>--- trunk/configure.ac Tue May 27 14:50:34 2008 (r31483)
>>>+++ trunk/configure.ac Tue May 27 15:54:29 2008 (r31484)
>>>@@ -402,6 +402,7 @@ fi
>>>
>>> AH_BOTTOM(
>>> #define N_(x) x
>>>+#define GETTEXT_NOOP(x)
>>> #ifdef ENABLE_NLS
>>> #include <locale.h>
>>> #include <libintl.h>
>>>
>>Not sure if you realized this yet, but this change breaks the build on
>>Win32: http://www.mobsol.be/buildbot/win32-xp%20VS2005/builds/463/step-Build/0.
>> You define the GETTEXT_NOOP macro in configure.ac, which is not used
>>on Windows.
>
>
> what a mess! This was really not my intention. Please note that I
> published my patch on this list before I committed (OK, I waited only 1
> day). I also improved my older patch based on a vague suggestion on this
> list so I tried my best :-)

Jens: Hey, don't worry about it. You did well. You are not being "told off". We
all miss stuff like that in a complex system. That's why we have other people
to review (before or after committing, both ways are good) and why we have testing.

(Sorry I can't help to fix it.)

- Julian

> I search before for definitions of the similar macro N_ and found it
> only in configure.ac so I added the new macro definition there too.
> $ trunk> grep -r "define *N_" . | grep -v .svn
> ./configure.ac:#define N_(x) x
>
> Can you please provide a fix for Windows? Even better commit yourself.
> I do not have access to such a system (it's non-free).
>
> PS: At least the two new messages should be merged into PO files in
> 1.5.x as otherwise even for currently fully translated languages such
> as fr, pl these two will occur English in two important help messages.
>
> Jens

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-28 10:47:44 CEST

This is an archived mail posted to the Subversion Dev mailing list.