[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] ISSUE #3193 Fix peg revision parsing for CLI repository root relative urls.

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Tue, 27 May 2008 09:57:55 -0400

Folker Schamel <schamel23_at_spinor.com> writes:
>>>> No need to strdup "" into a pool. Just assign "" directly; the static
>>>> storage won't hurt anyone, will it?
>>>>
>>> Ok, I'm still trying to get used to all this pool based things. The
>>> static storage is OK here because the string is never explicitly freed
>>> by the caller, just the pool is freed at some point in the future. Do
>>> I understand that correctly?
>>
>> Since "" is a constant, it almost certainly will be compiled as a
>> pointer to a fixed copy of the empty string in the program's text: no
>> dynamic allocation or freeing involved at all.
>
> Is it possible that the DLL containing the code is unloaded
> before the pool is destroyed?

?

I'm not sure I understand this question, but to the extent that I do
understand it, I think you might think something that isn't true.

There is no "the pool" as far as that empty string is concerned. It's
not allocated in a pool. Troy just meant that some other pool might be
cleared or destroyed, and that this wouldn't affect the statically
allocated (and probably shared) empty string.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-27 15:58:10 CEST

This is an archived mail posted to the Subversion Dev mailing list.