Re: [PATCH RFC] WIN32_RETRY_LOOP on Cygwin

Bernard Blackham wrote:
> I had to use the APR functions for detecting errors, as the previous
> errors were Win32-specific. Using APR_STATUS_IS_EACCES actually
> tests for many more errors than previously. This might hurt
> performance a little - I tried to measure it, but my checkout times
> vary quite wildly and any differences are lost in the noise here.
>

I'd really prefer to have the error checking part special-cased fro
Cygwin and Windows, so that the set of codes tested on Windows doesn't
change. I'm not so worried about the performance regression since it
would only manifest itself in cases where the operation would fail now;
but correctness is an issue.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-27 10:57:58 CEST