[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r31428 - in trunk/subversion: include libsvn_subr

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Sun, 25 May 2008 22:30:12 -0400

Arfrever Frehtes Taifersar Arahesis <arfrever.fta_at_gmail.com> writes:
>> Log:
>> Implement the 'password-stores' config option.
>>
>> --- trunk/subversion/libsvn_subr/cmdline.c (r31427)
>> +++ trunk/subversion/libsvn_subr/cmdline.c (r31428)
>> @@ -435,17 +435,45 @@ svn_cmdline_setup_auth_baton(svn_auth_ba
>>
>> [...]
>>
>> #ifdef SVN_HAVE_KWALLET
>> - if (get_auth_simple_provider(&provider, "kwallet", pool))
>> - {
>> - APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
>> + if (apr_strnatcmp(password_store, "kwallet") == 0)
>> + {
>> + if (get_auth_simple_provider(&provider, "kwallet", pool))
>> + {
>> + APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
>> + }
>> + continue;
>> + }
>> +#endif
>> + /* TODO: Error. */
>
> Which error code should be used for invalid value of DAV-unrelated
> configuration option?

SVN_ERR_AUTHN_NO_PROVIDER ?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-26 04:30:30 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.