[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bug: IP address bogusly interpreted as peg revision

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Sun, 25 May 2008 21:39:08 -0400

"Troy Curtis Jr" <troycurtisjr_at_gmail.com> writes:
> You know after thinking about it I could "fix" this behavior. I'm
> working on my revised patch right now and I think the trailing slash
> workaround would work if I returned "@" for no peg revision found
> instead of "" in my new fangled svn_opt__split_arg_at_peg_revision()
> function. This would mean that every single target coming out of the
> svn_client_args_to_target_array() would have a peg revision, but some
> of them would be blank.

What's the connection betweening return "@" instead of "" and making
trailing slashes prevent peg-revision interpretation?

I'd hate to see an improvement to our peg revision interpretation affect
APIs that way. Why can't we say "anything appearing before the last
slash in a path is not a peg revision" without having the API effect you
describe above?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-26 03:39:23 CEST

This is an archived mail posted to the Subversion Dev mailing list.