[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Issue 1796] defective or malicious client can corrupt repository log messages

From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
Date: Sat, 24 May 2008 19:11:39 +0300 (Jerusalem Daylight Time)

Daniel Shahaf wrote on Sat, 24 May 2008 at 18:58 +0300:
> Neels Janosch Hofmeyr wrote on Sat, 24 May 2008 at 17:04 +0200:
> > Daniel Shahaf wrote:
> > > neels_at_tigris.org wrote on Fri, 22 May 2008 at 22:04 -0000:
> > >> http://subversion.tigris.org/issues/show_bug.cgi?id=1796
> > >>
> > >
> > > According to my tests, 'svn' doesn't normalise log messages to CRLF now
> > > (though it would be nice if it did), so 'svn ci -m "foo\r\nbar"' or svn
> > > ci -F should do.
> >
> > Well, according to my tests ;), it does. Let's break down the different
> > cases, using r31375:
> >
> > === (1) ===
> > How would I make a -m "message" parameter with CR+LF in it? (like echo
> > -e)
> >
>
> -m "`printf`" ? -m "`cat CRLF-file`" ? python -c 'system()' ? Or throw
> it in a run_svn() call and see if it works :)
>

In case you haven't encountered it yet: run_svn() is an internal API of
the Python tests; see tests/cmdline/svntest/*.py.

> >
>

Thanks for working on this,

Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-24 18:12:01 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.