[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r31379 - in trunk:

From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
Date: Fri, 23 May 2008 14:53:39 +0300 (Jerusalem Daylight Time)

David Glasser wrote on Fri, 23 May 2008 at 00:57 -0700:
> On Thu, May 22, 2008 at 11:43 PM, Daniel Shahaf <d.s_at_daniel.shahaf.co.il> wrote:
> > glasser_at_tigris.org wrote on Thu, 22 May 2008 at 17:00 -0700:
> >> @@ -30,8 +30,8 @@ class TestHarness:
> >> def __init__(self, abs_srcdir, abs_builddir, logfile,
> >> base_url=None, fs_type=None, http_library=None,
> >> server_minor_version=None, verbose=None,
> >> - cleanup=None, enable_sasl=None, parallel=None, list_tests=None,
> >> - svn_bin=None):
> >> + cleanup=None, enable_sasl=None, parallel=None, config_file=None,
> > ^^^^^^^^^^^
> >> + list_tests=None, svn_bin=None):
> >> '''Construct a TestHarness instance.
> >>
> >
> > Adding the new argument broke the Windows tests, because win-tests.py
> > calls TestHarness this way:
> >
> > import run_tests
> > th = run_tests.TestHarness(abs_srcdir, abs_builddir,
> > os.path.join(abs_builddir, log),
> > base_url, fs_type, http_library,
> > server_minor_version, 1, cleanup,
> > enable_sasl, parallel, list_tests,
> > ^^^^^^^^^^
> > svn_bin)
> >
> > Not sure how to fix it; should config_file be supported on Windows?
>
> Honestly I'd suggest rewriting that function to not take a million arguments.
>

No opinion here, +1 to whatever you want to do to make it work again.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-23 13:53:59 CEST

This is an archived mail posted to the Subversion Dev mailing list.