[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: ra-serf bug

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Thu, 15 May 2008 19:54:54 +0200

Eric Gillespie wrote:
> ping :)
>
> Eric Gillespie <epg_at_pretzelnet.org> writes:
>
>> Lieven Govaerts <svnlgo_at_mobsol.be> writes:
>>
>>> Index: subversion/libsvn_ra_serf/property.c
>>> ===================================================================
>>> --- subversion/libsvn_ra_serf/property.c (revision 31082)
>>> +++ subversion/libsvn_ra_serf/property.c (working copy)
>>> @@ -612,6 +612,13 @@ svn_ra_serf__wait_for_props(svn_ra_serf__propfind_
>>> svn_error_clear(err);
>>> SVN_ERR(prop_ctx->parser_ctx->error);
>>> }
>>> + if (prop_ctx->parser_ctx->status_code == 404)
>> Looks like status_code is a pointer to the status code, so you
>> need to dereference it.

Right.

>> Even then, I still get the bogus dirent rather than NULL.
>
Attached is a second and better version of the patch. The 404 is now
converted to an error deeper in ra_serf code, which made svn with last
patch bail out while finding out the vcc/relative urls.

There might be other similar situations, so maybe this patch isn't
complete, but atleast it should solve your specific issue.

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org

Received on 2008-05-15 19:55:11 CEST

This is an archived mail posted to the Subversion Dev mailing list.