[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: kwallet final branch

From: Martin Furter <mf_at_rola.ch>
Date: Thu, 15 May 2008 19:05:57 +0200 (CEST)

On Thu, 15 May 2008, Ben Collins-Sussman wrote:

> On Thu, May 15, 2008 at 10:41 AM, Karl Fogel <kfogel_at_red-bean.com> wrote:
>> svncodereview_at_gmail.com writes:
>> > New code review comments by sussman have been published.
>> > Please go to http://codereview.appspot.com/989 to read them.
>>
>> Neat! But is there any way to configure it so that the (e.g.) output
>> below includes diff context along with the comments? The rest of this
>> mail is significantly less useful for not being self-contained: unless
>> one knows the code *really* well, one has to constantly flip back and
>> forth between the mail and other files / web pages in order to
>> understand the comments. I get that one is supposed to just go to the
>> main URL above (and I have), but presumably the rest of the mail was
>> intended to be useful...
>
> I don't think the mail is intended to be useful by itself. It's just
> an 'overview' of comments, and a signal that one should go to the real
> website and respond to the comment-annotations directly.

Isn't "useless email" called SPAM? ;)

Btw. is there no way to see all files with all diffs and comments at once?

> http://codereview.appspot.com/989/diff/1/7#newcode430
> Line 430: if (get_auth_simple_provider(&provider, "kwallet", pool))
> I'm confused here. Why does the kwallet provider need to dynamically
> load a whole new library, but keychain and windows providers don't?

DSO have many advantages. Please see this thread:
http://svn.haxx.se/dev/archive-2008-05/0054.shtml

Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-15 19:06:22 CEST

This is an archived mail posted to the Subversion Dev mailing list.