[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: kwallet branch is finished

From: Ben Collins-Sussman <sussman_at_red-bean.com>
Date: Thu, 15 May 2008 11:46:00 -0500

OK, I've reviewed the branch -- not the KDE-specific code, of course,
but the general auth-system changes it entails. Arfrever has
responded to my review with fixes, but there's only one issue I'm
still worried about.

Specifically, I don't understand why this change is creating an
entirely new svn_auth_kwallet.h public header file. As a rule, we try
to keep the number of public headers files to a minimum, to keep
things simpler for developers. This new header seems like a wart to
me; all it does is declare a new kwallet auth provider. And yet, our
other "conditional" auth providers (crytpostore on Windows, keychain
on OS X) are declared directly in svn_auth.h already.

Arfrever said that when his provider was declared directly within
svn_auth.h, that danielsh said it "broke the windows build" in IRC.
Can we have some more investigation on that problem, please, rather
than just turn a blind eye and create a new header? :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-15 18:46:46 CEST

This is an archived mail posted to the Subversion Dev mailing list.