[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

prop_tests 26 over neon (was: Re: [PATCH] Fix merging with broken softlink as target)

From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
Date: Tue, 13 May 2008 00:00:38 +0300 (Jerusalem Daylight Time)

Karl Fogel wrote on Mon, 12 May 2008 at 16:52 -0400:
> Daniel Shahaf <d.s_at_daniel.shahaf.co.il> writes:
> > Karl, does it pass without David's patch? I only ran file:// checks
> > here...
> >
> > (Normally I run either svnserveautocheck or davautocheck, chosen at
> > random)
>
> Erm, I'm pretty sure it does, because I had run the test suite earlier
> for some other changes. I'd check right now, but I have another patch
> in-tree that I'm testing while I review it (Troy Curtis'), so it would
> be hard to confirm that a pristine tree passes until that's done.
>
> -Karl
>

Thanks. I checked the buildbot now (should have done that before, too),
and it's my fault (not David's); the neon buildbot fails:

    EXPECTED STDERR (regexp):
    .*unexpected property value.*|.*Bogus date.*
    ACTUAL STDERR:
    subversion/libsvn_ra_neon/fetch.c:1175: (apr_err=175002)
    svn: DAV request failed; it's possible that the repository's pre-revprop-change hook either failed or is non-existent
    subversion/libsvn_ra_neon/props.c:1151: (apr_err=175008)
    svn: At least one property change failed; repository is unchanged
    subversion/libsvn_ra_neon/util.c:206: (apr_err=175002)
    svn: Error setting property 'date':
    Could not execute PROPPATCH.
    EXCEPTION: SVNUnmatchedError
    Traceback (most recent call last):
      File "/Users/lgo/slavedir/osx10.4-gcc4.0.1-ia32/build/subversion/tests/cmdline/svntest/main.py", line 1083, in run
        rc = apply(self.pred.run, (), kw)
      File "/Users/lgo/slavedir/osx10.4-gcc4.0.1-ia32/build/subversion/tests/cmdline/svntest/testcase.py", line 121, in run
        return self.func(sandbox)
      File "/Users/lgo/slavedir/osx10.4-gcc4.0.1-ia32/build/subversion/tests/cmdline/prop_tests.py", line 1649, in invalid_propvalues
        repo_url)
      File "/Users/lgo/slavedir/osx10.4-gcc4.0.1-ia32/build/subversion/tests/cmdline/svntest/actions.py", line 211, in run_and_verify_svn
        expected_exit, *varargs)
      File "/Users/lgo/slavedir/osx10.4-gcc4.0.1-ia32/build/subversion/tests/cmdline/svntest/actions.py", line 248, in run_and_verify_svn2
        verify.verify_outputs(message, out, err, expected_stdout, expected_stderr)
      File "/Users/lgo/slavedir/osx10.4-gcc4.0.1-ia32/build/subversion/tests/cmdline/svntest/verify.py", line 331, in verify_outputs
        compare_and_display_lines(message, label, expected, actual, raisable)
      File "/Users/lgo/slavedir/osx10.4-gcc4.0.1-ia32/build/subversion/tests/cmdline/svntest/verify.py", line 303, in compare_and_display_lines
        raise raisable
    SVNUnmatchedError
    FAIL: prop_tests.py 26: test handling invalid svn:* property values
    END: prop_tests.py

Based on the comment in prop_tests.py:test_list,

              # If we learn how to write a pre-revprop-change hook for
              # non-Posix platforms, we won't have to skip here:
              # TODO(epg): Removed Skip as long as we have this XFail
              # because I couldn't get Skip and XFail to interact
              # properly (it kept showing the failure and then
              # printing PASS instead of XFAIL).
              #Skip(revprop_change, is_non_posix_and_non_windows_os),
              XFail(revprop_change, svntest.main.is_ra_type_dav),

I assume that the correct fix is to mark test 26 (which requires
revprop changes to be enabled) as XFail over DAV.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-12 23:00:57 CEST

This is an archived mail posted to the Subversion Dev mailing list.