[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: ra-serf bug

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Fri, 09 May 2008 10:33:17 +0200

Karl Fogel wrote:
> Eric Gillespie <epg_at_pretzelnet.org> writes:
>> Got another one for you: svn_ra_stat is supposed to return NULL
>> for the dirent for paths that do not exist; local/svn/neon do,
>> but serf just returns a bogus one:
>
> Just looking into this briefly between beer and bed (no, really):
>
> Would a non-existent path be indicated by a particular value in
> prop_ctx->status_code after svn_ra_serf__wait_for_props() is done? I'm
> talking about in serf.c:fetch_path_props(). The call to that function
> in svn_ra_serf__stat() seems like the only chance we'd have to discover
> the path does not exist.
>
The equivalent ra_neon code in svn_ra_neon__do_stat uses a 404 response
code when fetching the properties to set dirent to NULL.

Attached (untested, no log msg) patch should solve this problem.

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org

Received on 2008-05-09 10:33:35 CEST

This is an archived mail posted to the Subversion Dev mailing list.