[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] [gnome-keyring] Miscellaneous improvements

From: Arfrever Frehtes Taifersar Arahesis <arfrever.fta_at_gmail.com>
Date: Thu, 1 May 2008 20:01:42 +0200

[[[
On the 'gnome-keyring' branch:
Miscellaneous improvements.

* configure.ac: Rename the '--enable-gnome-keyring' option to
   '--with-gnome-keyring' and rewrite it to fix its behavior.
   Define SVN_GNOME_KEYRING_INCLUDES and SVN_GNOME_KEYRING_LIBS
   variables and mark them for substitution.

* Makefile.in
  (SVN_GNOME_KEYRING_LIBS): New.
  (INCLUDES): Add @SVN_GNOME_KEYRING_INCLUDES@.

* build.conf
  (libsvn_subr.libs): Add gnome-keyring.
  (gnome-keyring): Implement.

* subversion/include/svn_auth.h
  (svn_auth_get_gnome_keyring_simple_provider):
* subversion/libsvn_subr/simple_providers.c
  (gnome_keyring_password_get, gnome_keyring_password_set,
   gnome_keyring_simple_first_creds, gnome_keyring_simple_save_creds,
   gnome_keyring_simple_provider, svn_auth_get_gnome_keyring_simple_provider):
   Be always declared/defined but actually work only when
   SVN_HAVE_GNOME_KEYRING is defined.

* configure.ac:
* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_setup_auth_baton):
* subversion/libsvn_subr/simple_providers.c:
   Rename SVN_HAVE_GNOME_KEYRING_SERVICES to SVN_HAVE_GNOME_KEYRING.

Patch by: arfrever
]]]

When GNOME Keyring was found, SVN_HAVE_GNOME_KEYRING is defined in
svn_private_config.h but this file is never installed.
I think that svn_auth_get_gnome_keyring_simple_provider should be always
defined but it shouldn't provide real support for GNOME Keyring when
Subversion was built without --with-gnome-keyring.

SVN_HAVE_KEYCHAIN_SERVICES contains "_SERVICES" because the API used to access
Keychain is called "Keychain Services".
http://developer.apple.com/documentation/Security/Conceptual/keychainServConcepts/index.html
This suffix isn't necessary for SVN_HAVE_GNOME_KEYRING.

-- 
Arfrever Frehtes Taifersar Arahesis

Received on 2008-05-01 20:06:46 CEST

This is an archived mail posted to the Subversion Dev mailing list.