Stefan Sperling wrote on Tue, 29 Apr 2008 at 17:30 +0200:
> On Tue, Apr 29, 2008 at 03:42:34AM -0700, danielsh_at_tigris.org wrote:
> > Author: danielsh
> > Date: Tue Apr 29 03:42:34 2008
> > New Revision: 30835
> >
> > Log:
> > Do not abort in svn_handle_error2().
> >
> > Suggested by: stsp
>
> It wasn't just me! brane should be added to the list of suggesters:
>
Propedited. Sorry, brane.
Further credit to Malcolm, whose r24415 log message was very helpful in
analyzing the aborts (maintainer-mode and otherwise). (But he didn't
suggest this specific change)
> > fflush(stream);
> > if (fatal)
> > - /* XXX Shouldn't we exit(1) here instead, so that atexit handlers
> > - get called? --xbc */
> > - abort();
>
>
> > + {
> > + /* Avoid abort()s in maintainer mode. */
> > + svn_error_clear(err);
> > +
> > + /* We exit(1) here instead of abort()ing so that atexit handlers
> > + get called. */
> > + exit(EXIT_FAILURE);
>
> I'd prefer:
>
> /* We exit() here instead of abort()ing so that atexit handlers
>
> Saying "exit(1)" and doing "exit(EXIT_FAILURE)" is apparently the
> same thing, but it looks odd. </bikeshed>
>
When I wrote "exit(1)" I meant "exit() with a non-zero code".
+1 if you want to change it.
> > + }
> > }
>
>
Thanks Stefan.
Daniel
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-29 21:00:01 CEST