Re: svn commit: r30835 - in trunk/subversion: include libsvn_subr

On Tue, Apr 29, 2008 at 03:42:34AM -0700, danielsh_at_tigris.org wrote:
> Author: danielsh
> Date: Tue Apr 29 03:42:34 2008
> New Revision: 30835
>
> Log:
> Do not abort in svn_handle_error2().
>
> Suggested by: stsp

It wasn't just me! brane should be added to the list of suggesters:

> fflush(stream);
> if (fatal)
> - /* XXX Shouldn't we exit(1) here instead, so that atexit handlers
> - get called? --xbc */
> - abort();

> + {
> + /* Avoid abort()s in maintainer mode. */
> + svn_error_clear(err);
> +
> + /* We exit(1) here instead of abort()ing so that atexit handlers
> + get called. */
> + exit(EXIT_FAILURE);

I'd prefer:

  /* We exit() here instead of abort()ing so that atexit handlers

Saying "exit(1)" and doing "exit(EXIT_FAILURE)" is apparently the
same thing, but it looks odd. </bikeshed>

> + }
> }

-- 
Stefan Sperling <stsp_at_elego.de>                    Software Monkey
 
German law requires the following banner :(
elego Software Solutions GmbH                            HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12        Tel:  +49 30 23 45 86 96 
13355 Berlin                              Fax:  +49 30 23 45 86 95
http://www.elego.de                               CEO: Olaf Wagner
 
Store password unencrypted (yes/no)? No