[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix --depth behavior for svn add (Re: Semantics of --depth: should define WC-depth for omitted-items?)

From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
Date: Fri, 25 Apr 2008 19:50:09 +0300 (Jerusalem Daylight Time)

Rui, Guo wrote on Sat, 26 Apr 2008 at 00:19 +0800:
> PS: I'm really not good at splitting a unified patch into logical independent
> changes sets. What's the best way of handling this? I just edit the patch file
> by hand this time and not sure about whether they are still valid.
>

You could use the (new in 1.5) changelists feature, and do 'svn diff
--cl CLNAME' to get the diff for changelist CLNAME.

Is there an easy way, however, to get 'svn diff' to output files' diffs
a particular order?

> Here are change logs for the patch:
> [[[
> Make the --depth option in svn add works in the same way with svn ci, up etc.
> ]]]
>
> And I also made some cleanups for the code:
> [[[
> Some cleanups:
> ]]]
>

(patch manager hat on)

Rui, it would be easier to review your patches if you said which log
message goes with which patch (although, this time, I could guess it from
the filenames). You might also include the log message at the top of the
patch file (patch(1) would ignore it).

Daniel

> Rui, Guo
> On Tue, Apr 22, 2008 at 11:10:47AM -0400, Karl Fogel wrote:
> > "Rui, Guo" <timmyguo_at_mail.ustc.edu.cn> writes:
> > >> I think I do too -- that is, the operational depth becomes the "set"
> > >> depth for added trees. Would you like to try writing the patch?
> > >
> > > Certainly I would like to. However, it may take me some time to handle
> > > this, since this will be my first patch on the code. :)
> >
> > Well, since your Summer of Code project was accepted (congratulations),
> > this is a good place to start! :-)
> >
> > We're always here for questions, of course.
> >
> > -Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-25 18:50:34 CEST

This is an archived mail posted to the Subversion Dev mailing list.