[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svneditor.bat

From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
Date: Mon, 21 Apr 2008 09:11:31 +0300

Karl Fogel wrote on Mon, 21 Apr 2008 at 01:48 -0400:
> Daniel Shahaf <d.s_at_daniel.shahaf.co.il> writes:
> > The testsuite on Windows assumes that *.py files are executable by saying
> > their name. The following patch removes this assumption. For me, the
> > tests fail without it.
> >
> > This is consistent with INSTALL, which prefixes "python " to every example
> > of running a Python script on Windows.
>
> Hmmm. No real objection to the patch (I don't have a Windows system to
> test it on, though). I do wonder why we haven't heard about this
> problem before... Can you think of any reason why the tests don't run
> for you but not (apparently) for others? If there's some idiosyncracy
> about your system, or about our tests, this is a good chance to uncover
> it.
>

If one associates *.py files to python.exe, then whenever one says
"foo.py" or double-clicks foo.py's icon, "python.exe foo.py" would be run.

However, on my Windows box I associate *.py files to nothing, therefore
when svneditor.bat runs svneditor.py I get an "Extension is not
associated, what application would you like to view the file with?" dialog
(for svneditor.py). I cancel the dialog, svneditor doesn't get run, and
the test fails.

Daniel

> -Karl
>
> > [[[
> > * subversion/tests/cmdline/svneditor.bat:
> > Call python.exe to run a python script.
> > ]]]
> >
> > Index: subversion/tests/cmdline/svneditor.bat
> > ===================================================================
> > --- subversion/tests/cmdline/svneditor.bat (revision 30700)
> > +++ subversion/tests/cmdline/svneditor.bat (working copy)
> > @@ -1,5 +1,5 @@
> > @echo off
> > rem the svneditor.py script is expected to be in the same directory as the
> > rem .bat file
> > -%~dp0\svneditor.py %*
> > +python %~dp0\svneditor.py %*
> > exit %ERRORLEVEL%
> > \ No newline at end of file
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
> > For additional commands, e-mail: dev-help_at_subversion.tigris.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-22 09:11:49 CEST

This is an archived mail posted to the Subversion Dev mailing list.