[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svneditor.bat

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Mon, 21 Apr 2008 01:48:24 -0400

Daniel Shahaf <d.s_at_daniel.shahaf.co.il> writes:
> The testsuite on Windows assumes that *.py files are executable by saying
> their name. The following patch removes this assumption. For me, the
> tests fail without it.
>
> This is consistent with INSTALL, which prefixes "python " to every example
> of running a Python script on Windows.

Hmmm. No real objection to the patch (I don't have a Windows system to
test it on, though). I do wonder why we haven't heard about this
problem before... Can you think of any reason why the tests don't run
for you but not (apparently) for others? If there's some idiosyncracy
about your system, or about our tests, this is a good chance to uncover
it.

-Karl

> [[[
> * subversion/tests/cmdline/svneditor.bat:
> Call python.exe to run a python script.
> ]]]
>
> Index: subversion/tests/cmdline/svneditor.bat
> ===================================================================
> --- subversion/tests/cmdline/svneditor.bat (revision 30700)
> +++ subversion/tests/cmdline/svneditor.bat (working copy)
> @@ -1,5 +1,5 @@
> @echo off
> rem the svneditor.py script is expected to be in the same directory as the
> rem .bat file
> -%~dp0\svneditor.py %*
> +python %~dp0\svneditor.py %*
> exit %ERRORLEVEL%
> \ No newline at end of file
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: dev-help_at_subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-22 07:49:12 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.