[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r30684 - in trunk/subversion: include libsvn_client libsvn_ra svnsync tests/cmdline tests/libsvn_ra_local

From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
Date: Sun, 20 Apr 2008 22:59:15 +0300

David Glasser wrote on Sun, 20 Apr 2008 at 12:41 -0700:
> On Fri, Apr 18, 2008 at 9:56 AM, <kfogel_at_tigris.org> wrote:
> > Author: kfogel
> > Date: Fri Apr 18 09:56:09 2008
> > New Revision: 30684
> >
> > Log:
> > Check repository UUID when creating an RA session. This fixes an
> > issue where "svn update" would silently overwrite the UUID of a
> > working copy if the repository UUID had changed. Several tests in
> > svnadmin_tests which silently took advantage of this are fixed too.
> >
> > --- trunk/subversion/libsvn_client/ra.c Fri Apr 18 08:57:47 2008 (r30683)
> > +++ trunk/subversion/libsvn_client/ra.c Fri Apr 18 09:56:09 2008 (r30684)
> > @@ -291,6 +291,7 @@ svn_client__open_ra_session_internal(svn
> > {
> > svn_ra_callbacks2_t *cbtable = apr_pcalloc(pool, sizeof(*cbtable));
> > svn_client__callback_baton_t *cb = apr_pcalloc(pool, sizeof(*cb));
> > + const char *uuid = NULL;
> >
> > cbtable->open_tmp_file = use_admin ? open_admin_tmp_file : open_tmp_file;
> > cbtable->get_wc_prop = use_admin ? get_wc_prop : NULL;
> > @@ -310,7 +311,17 @@ svn_client__open_ra_session_internal(svn
> > cb->commit_items = commit_items;
> > cb->ctx = ctx;
> >
> > - SVN_ERR(svn_ra_open2(ra_session, base_url, cbtable, cb,
> > + if (base_access)
> > + {
> > + svn_wc_entry_t *entry;
> > +
> > + SVN_ERR(svn_wc_entry(&entry, base_dir, base_access, FALSE, pool));
>
> I get a warning on this line; I think it wants entry to be const?
>

Yes it does. Sorry about that; I fixed it here, but forgot to
convey the fix to the list.

Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-20 21:59:20 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.