Stefan Sperling wrote on Sat, 19 Apr 2008 at 21:26 +0200:
> On Sat, Apr 19, 2008 at 08:26:55PM +0300, Daniel Shahaf wrote:
> > > + const char *answer = NULL;
> > > + svn_boolean_t answered = FALSE;
> > > + const char *prompt_string = _("Store password unencrypted (yes/no)? ");
> > >
> > > + SVN_ERR(svn_cmdline_printf(pool, "\n"));
> >
> > You could call svn_cmdline_printf() just once (passing a multiline
> > string); don't know if it matters.
>
> Indeed. Fixed, thanks.
>
After the fix you have five invocations of svn_cmdline_printf(),; you
could do it in one. Compare subversion/svn/conflict-callbacks.c:418.
Interestingly, there the prompt prints to stderr -- should we do the same
here? (I think we should -- it is not unusual to redirect 'log' or 'diff'
output to a file.)
> > Also, in three places whitespace is missing:
> >
> > > --- subversion/libsvn_subr/simple_providers.c (.../trunk) (revision 30656)
> > > +++ subversion/libsvn_subr/simple_providers.c (.../branches/dont-save-plaintext-passwords-by-default) (revision 30710)
> > > @@ -238,13 +246,21 @@ simple_save_creds_helper(svn_boolean_t *saved,
> > > + svn_boolean_t non_interactive = apr_hash_get(parameters,
> > > SVN_AUTH_PARAM_NON_INTERACTIVE,
> > > APR_HASH_KEY_STRING) != NULL;
> >
> > here,
>
> Woah, that must've been vim, it certainly wasn't me :)
>
I know what you mean. :)
> > I'll leave you alone now. :)
>
> Thanks so much for your input! :)
>
>
Thanks,
Daniel
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-19 22:21:26 CEST