[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r30485 - in branches/gnome-keyring: . subversion/include subversion/libsvn_subr

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Mon, 14 Apr 2008 13:59:34 +0200

On Fri, Apr 11, 2008 at 1:52 AM, Eric Gillespie <epg_at_google.com> wrote:
> Eric Gillespie <epg_at_google.com> writes:
>
> > Lieven Govaerts <svnlgo_at_mobsol.be> writes:
> >
> > > Eric Gillespie wrote:
> > > > Lieven Govaerts <svnlgo_at_mobsol.be> writes:
> > > >
> > > >> I thought we had a constant somewhere with the name of the application
> > > >> in it, but we don't. Fact is, if there's a gnome equivalent for
> > > >> TortoiseSVN, we should be able to show that name in the password popup
> > > >> instead of Subversion.
> > > >
> > > > I don't think so; two separate Subversion frontends should be
> > > > able to share this data.
> > > >
> > > I don't mean storing it under GnomeSVN or whatever, I'm talking about
> > > the title of the Keyring manager popup window which now says something
> > > like 'Application svn wants to save a password' Deny/Allow.
> >
> > I realize that, but it's not "TortoiseSVN" or "NautiluSVN" or
> > whatever that's being configured here.
>
> Actually, upon rereading your change, I retract my position here.
> This stuff isn't keyed on the application *at all*, it's only the
> username and realm string.

Nope, the 'realmstring' is specific to Subversion, it's not only the
realm provided by the server.

In fact, he realmstring is provided by the ra_* layers, and is
implemented the same for ra_neon and ra_serf:

      /* <https://svn.collab.net:80> Subversion repository */
      realmstring = apr_psprintf(ras->pool, "<%s://%s:%d> %s",
                                 ras->root.scheme, ras->root.host,
                                 ras->root.port, realm);

>
> - I hope that realmstring includes not just the repository realm
> but also the URL :)

Well, it's not the URL of the repository, but from the whole server.

>
> - Subversion > svn

I propose to add an API to set the application name, and use
Subversion as default.

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-14 14:00:00 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.