[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r30375 - trunk/subversion/libsvn_ra_serf

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Sat, 12 Apr 2008 10:15:52 +0200

Arfrever Frehtes Taifersar Arahesis wrote:
> 2008-04-06 17:39:14 lgo_at_tigris.org napisaƂ(a):
>> Author: lgo
>> Date: Sun Apr 6 08:39:14 2008
>> New Revision: 30375
>>
>> Log:
>> ra_serf: Fix issue #3167: when the repository is on the root of the server,
>> make sure we pass "/" as our relative path in the request. This requires a
>> workaround for what seems like a bug in apr-util's uri parsing functionality.
>>
>> * subversion/libsvn_ra_serf/serf.c
>> (svn_ra_serf__open): When passing an url with an empty relative path to the
>> apr_uri_parse function, the resulting uri.path string will be NULL, as
>> opposed to what the documentation says. In this case, we have to overwrite
>> this value in the uri structure.
>>
>> Modified:
>> trunk/subversion/libsvn_ra_serf/serf.c
>>
>> Modified: trunk/subversion/libsvn_ra_serf/serf.c
>> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_ra_serf/serf.c?pathrev=30375&r1=30374&r2=30375
>> ==============================================================================
>> --- trunk/subversion/libsvn_ra_serf/serf.c Sun Apr 6 07:12:46 2008 (r30374)
>> +++ trunk/subversion/libsvn_ra_serf/serf.c Sun Apr 6 08:39:14 2008 (r30375)
>> @@ -499,6 +499,9 @@ svn_ra_serf__open(svn_ra_session_t *sess
>> _("Illegal repository URL '%s'"),
>> repos_URL);
>> }
>> + /* Work around an issue in apr-util 1.2.12 and older */
>
> Your patch for APR-Util seems to have been rejected [1], so the above comment probably should be changed.
>

Yep, updated in 30561.

thx for the review,

Lieven.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-12 10:16:15 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.