[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: revision number output in 'svn mergeinfo' command

From: Paul Burba <ptburba_at_gmail.com>
Date: Sat, 5 Apr 2008 10:15:08 -0400

On Sat, Apr 5, 2008 at 10:03 AM, Karl Fogel <kfogel_at_red-bean.com> wrote:
> I have a simple, self-explanatory patch I'd like to apply & backport,
> for consistency in how we present revision numbers. Anyone think this
> is nuts?
>
> [[[
> Brand management: when printing out revision numbers, use the "r" prefix.
>
> * subversion/svn/mergeinfo-cmd.c
> (print_log_rev): Make it so.
> ]]]
>
> Index: subversion/svn/mergeinfo-cmd.c
> ===================================================================
> --- subversion/svn/mergeinfo-cmd.c (revision 30326)
> +++ subversion/svn/mergeinfo-cmd.c (working copy)
> @@ -43,7 +43,7 @@
> svn_log_entry_t *log_entry,
> apr_pool_t *pool)
> {
> - svn_cmdline_printf(pool, "%ld\n", log_entry->revision);
> + svn_cmdline_printf(pool, "r%ld\n", log_entry->revision);
> return SVN_NO_ERROR;
> }

We've talked so much, for so long, about 'svn mergeinfo' that I don't
recall if anyone ever had a reason not to include the 'r' prefix on
the output. I don't see why not though, it fits with how we typically
display revisions on the command line.

Paul

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-05 16:15:20 CEST

This is an archived mail posted to the Subversion Dev mailing list.