[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Adding svn_client_init() (was: from main.c)

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Fri, 04 Apr 2008 17:47:54 -0400

Jack Repenning <jackrepenning_at_tigris.org> writes:
>> /* ### This really belongs in libsvn_client. The trouble is,
>> there's no one place there to run it from, no
>> svn_client_init(). We'd have to add it to all the public
>> functions that a client might call. It's unmaintainable to do
>> initialization from within libsvn_client itself, but it seems
>> burdensome to demand that all clients call svn_client_init()
>> before calling any other libsvn_client function... On the other
>> hand, the alternative is effectively to demand that they call
>> svn_config_ensure() instead, so maybe we should have a generic
>> init function anyway. Thoughts? */
>> err = svn_config_ensure(opt_state.config_dir, pool);
>
> My thought: yes, there might as well / ought to be something like
> svn_client_init(). Speaking as a client (SCPlugin) who's only today
> figuring out that we have this obligation to call svn_config_ensure(),
> but very likely would have looked for an init() routine years ago.
>
> But I suppose I'm about five years too late on this one. Perhaps, at
> least, a note in the "Using the APIs" chapter of The Book, or
> something?

There is no reason we couldn't add svn_client_init() now, and call
svn_client_init() from it, and document both so that the history here is
clear, and make the change you suggest to the book and wherever else.

Anyone object?

> By the way, does anyone know any *other* stuff I really ought to do,
> being a libsvn_client client an' all?

Did you plug it in?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-04 23:48:06 CEST

This is an archived mail posted to the Subversion Dev mailing list.