On Wed, Apr 2, 2008 at 2:45 PM, Branko ╚ibej <brane_at_xbc.nu> wrote:
> jeremy hinds wrote:
> > I will be posting an updated patch in a separate email. While working
> > on it, I found a couple of things that I wanted to bring up:
> > 1) In cmdline/svntest/main.py (function: run_one), there is a comment
> > that says "don't trust the exitcode [from spawn_process()], will not
> > be correct on Windows". Python docs say that wait() is supported on
> > Unix only, so this may be the reason. I'll try to dig around for more
> > info, but if exit codes cannot be reliably gotten on Windows, must I
> > wrap a check against "main.is_posix_os()" around the exit-code
> > verification?
> I think we should move all that code to use the subprocess module. I know
> it requires python-2.4, but frankly, I don't care if it makes the test suite
> more useful.
> I know I've seen our tests report false positives because we weren't
> looking at exit codes.
I believe we decided a while ago that we were totally fine with
bumping the Python requirement for the test suite.
David Glasser | firstname.lastname@example.org | http://www.davidglasser.net/
Received on 2008-04-04 20:14:10 CEST