[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Understanding the delta editor's set_target_revision()

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Fri, 04 Apr 2008 15:43:36 +0100

Can anyone shed light on the meaning and purpose of "set_target_revision()" in
the delta editor?

I'm just trying to understand this for tree-conflicts work, as it might be
relevant for helping to detect whether the working copy being edited matches
the merge-left source.

[[[
--- subversion/include/svn_delta.h (revision 30178)

  typedef struct svn_delta_editor_t
  {
    /** Set the target revision for this edit to @a target_revision. This
     * call, if used, should precede all other editor calls.
+ * ### What's a "target revision"? Why is it implicitly optional?
     */
    svn_error_t *(*set_target_revision)(void *edit_baton,
                                        svn_revnum_t target_revision,
                                        apr_pool_t *pool);

@@ -754,17 +755,19 @@ typedef struct svn_delta_editor_t

    /** We are going to make changes in a subdirectory (of the directory
     * identified by @a parent_baton). The subdirectory is specified by
     * @a path. The callback must store a value in @a *child_baton that
     * should be used as the @a parent_baton for subsequent changes in this
     * subdirectory. If a valid revnum, @a base_revision is the current
+ * ### "current" means what?
     * revision of the subdirectory.
+ * ### ... to be used only for sanity checking (?)
     *
     * Allocations for the returned @a child_baton should be performed in
     * @a dir_pool. It is also typical to (possibly) save this pool for later
     * usage by @c close_directory.
     */
    svn_error_t *(*open_directory)(const char *path,
                                   void *parent_baton,
                                   svn_revnum_t base_revision,
]]]

Thanks for any help.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-04 16:43:55 CEST

This is an archived mail posted to the Subversion Dev mailing list.